extend apport excepthook detection to also detect partial_apport_excepthook #2838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2464
A slighly more general fix would be
if "apport_excepthook" in getattr(sys.excepthook, "__name__", "")
in case they make another slight change to the name of the function.The issue mentioned that this broke as they updated to Ubuntu 22.10, and all the ubuntu builds in our CI runs on 22.04, which I assume is why this wasn't picked up by the test suite.
It would be great if @Adrien-Luxey or somebody else with easy access to an ubuntu 22.10 machine could run the test suite on master and then this PR to see if it is fixed.
Checking https://github.com/actions/runner-images#available-images it looks like 22.04 is the only available image, so would require a bunch of extra work to get this tested in CI.