-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add a per test 3min timeout and enable color output #700
Conversation
c66bda1
to
0b7f73a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #700 +/- ##
==========================================
+ Coverage 96.76% 96.79% +0.02%
==========================================
Files 27 27
Lines 3557 3557
==========================================
+ Hits 3442 3443 +1
+ Misses 115 114 -1 ☔ View full report in Codecov by Sentry. |
I keep seeing this error also (it appears to be a string returned from the codecov api):
Setting codecov-actions to verbose doesn't seem to give any more details. 🤔 |
I think the timeout is ok.
If the tests did not complete in 1h, they are not going to complete ever.
…On Sun, Jan 29, 2023, 16:17 Jon Bringhurst ***@***.***> wrote:
I keep seeing this error also (it appears to be a string returned from the
codecov api):
Could not determine repo and owner
🤔
—
Reply to this email directly, view it on GitHub
<#700 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIFTHSG3HX2FDX6GV7XPXTWU3M6FANCNFSM6AAAAAAUKOK74U>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
0b7f73a
to
d040b30
Compare
I wonder if this is why you see the codecov things, as it tries leverage the Github App. @ceache I don't have the rights to add the app. Do you know someone who does? |
66850d3
to
55a242d
Compare
An example of this showing useful debug output: https://github.com/python-zk/kazoo/actions/runs/4038897905/jobs/6943223749 It lets the pytest timeout (not github actions timeout) determine that the test failed and prints out a trace of all frames. |
33e4705
to
51fa4d5
Compare
It looks like this job may time out -- https://github.com/python-zk/kazoo/actions/runs/4039044495/jobs/6943463553 If that works correctly (times out and shows stack traces), I'll open this up for review. Edit: It looks like this shows a nice stacktrace. |
51fa4d5
to
7a10de2
Compare
7a10de2
to
f6126bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to try it, and keep it as long as it's useful!
I do wonder whether this is just actions infra being flaky from time to time, or if we've got some bugs in our code that are hiding... could just be Zookeeper occasionally flaking as it comes up, I know I've seen that from time to time although no idea if that's Zookeeper, or Docker or something else...
f6126bb
to
8d8dcf5
Compare
8d8dcf5
to
e2ad96b
Compare
e2ad96b
to
091ee68
Compare
091ee68
to
5bdd8ee
Compare
I have resurrected this PR and reduced the @jeffwidman @a-ungurianu @ceache if you have some time to check it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Why is this needed?
It's difficult to reproduce, but I've seen the github actions test suite take more than 6 hours. Having a timeout set will allow us to get some sort of useful debug information instead of having github actions kill it off before we can analyze anything.
Proposed Changes
Does this PR introduce any breaking change?
No -- this is intended to help debug the test suite.