Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reviewing some PRs and cutting a new release? #73

Closed
4 of 5 tasks
Jackenmen opened this issue Aug 14, 2022 · 3 comments
Closed
4 of 5 tasks

Consider reviewing some PRs and cutting a new release? #73

Jackenmen opened this issue Aug 14, 2022 · 3 comments

Comments

@Jackenmen
Copy link
Contributor

Jackenmen commented Aug 14, 2022

Hi there, thanks for making (and maintaining) this cool project!

I would want to ask the maintainers of this project to consider reviewing at least some of the open PRs and cutting a new release. About a year ago I wanted to help out with cleaning out the issue tracker so I've made a bunch of PRs (some of which have already been merged but not released: #58, #61, #40) with fixes and enhancements. There has been no new release since November, and I feel like there's already a decent chunk of unreleased changes (other than my own PRs, there's also #63 adding support for --mirror) that could be made available to everyone using cherry-picker.

Here's the list of not-yet merged PRs that pass tests and aren't a draft:

I personally think that the single most important PR here is #46 because the lack of attribution just plain sucks when it's really the only thing that as a contributor to an open source project you can expect.
#35 fixes an issue of a CPython's core developer so that would probably be good to have but there are some open questions in the PR for it which may not make it possible to review at the current point in time.
Other than that, I think that #43 probably makes the most important fixes as it makes cherry_picker easier to use when you have to resolve conflicts which is probably the only time when CPython's core developers have to actually use cherry_picker manually so making that process better is IMO helpful.
Personally, I have a stake in #70 but I don't imagine it being useful to a lot of people, and definitely not useful for CPython workflow so that's just on my wishlist 😄

I hope this summary is helpful.

I'm not trying to demand anything here, it is a voluntarily-maintained project. All I want is for you to consider my ask, nothing more :)

@ezio-melotti
Copy link
Member

Thanks for putting this together. I left a few minor comments in some of the linked PRs.
cc @ambv, @Mariatta

@Jackenmen
Copy link
Contributor Author

Since it's getting close to a year, I figured this might be the right time to bump this (also got a notification on #70 so I kinda got reminded of this). We're really just left with #70 which may have been partially reviewed by @Mariatta as I was requested to and made the changes on it but since it's been a year that will probably just need a fresh review. After that, someone (Mariatta or Łukasz, I guess?) would just need to cut a new release since there isn't anything else left from PRs.

@Jackenmen
Copy link
Contributor Author

It's probably not worth keeping this open with 2.2.0 release that happened yesterday since there's only one PR on the list that hasn't been merged and that can be tracked in the PR itself. Thank you for working on getting the new release out, @Mariatta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants