Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoconf: Update autoconf image file to use Ubuntu distro #13

Merged
merged 5 commits into from
Oct 6, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Sep 27, 2024

  • Port autoconf image from alpine distro to Ubuntu distro.

Comment on lines 15 to 20
autotools-dev \
autoconf \
autoconf-archive \
build-essential \
curl \
pkg-config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit; I'd prefer to keep the extra indent, to make it obvious that these are arguments to apt-get and not a new chain of commands :)


RUN set -o pipefail \
&& curl https://ftp.gnu.org/gnu/autoconf/autoconf-${AUTOCONF_VERSION}.tar.gz | tar -zxf - \
RUN curl https://ftp.gnu.org/gnu/autoconf/autoconf-${AUTOCONF_VERSION}.tar.gz | tar -zxf - \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it not work with pipefail?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: b200e7a

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: b200e7a

Elegant!

@corona10
Copy link
Member Author

corona10 commented Oct 1, 2024

Hmm https://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz is unstable.

@corona10

This comment was marked as resolved.

@corona10
Copy link
Member Author

corona10 commented Oct 6, 2024

@erlend-aasland gentle ping~

@corona10 corona10 merged commit 7a68613 into python:main Oct 6, 2024
4 checks passed
@corona10 corona10 deleted the autoconf-ubuntu branch October 6, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants