Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoconf: Update autoconf image file to use Ubuntu distro #13

Merged
merged 5 commits into from
Oct 6, 2024
Merged

autoconf: Update autoconf image file to use Ubuntu distro #13

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63a6cac
autoconf: Update autoconf image file to use Ubuntu distro
corona10 Sep 27, 2024
8747aa6
Address code review
corona10 Oct 1, 2024
7412b9a
nit
corona10 Oct 2, 2024
7352cee
Reset pipefail
corona10 Oct 2, 2024
b200e7a
fix
corona10 Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions autoconf/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM docker.io/library/alpine:3.20
FROM docker.io/library/ubuntu:22.04

ARG AUTOCONF_VERSION="2.71"
ARG AUTOCONF_ARCHIVE_VERSION="2023.02.20"
Expand All @@ -10,37 +10,34 @@ LABEL org.opencontainers.image.authors="Donghee Na"
LABEL org.opencontainers.image.title="GNU Autoconf ${AUTOCONF_VERSION} container for CPython"
LABEL org.opencontainers.image.description="Container image with GNU Autoconf ${AUTOCONF_VERSION}, GNU Automake ${AUTOMAKE_VERSION}, and autoconf-archive ${AUTOCONF_ARCHIVE_VERSION} for generating CPython's configure script."

RUN apk upgrade && \
apk add \
curl \
alpine-sdk \
autoconf \
automake \
pkgconfig \
xz
RUN apt-get update && \
apt-get install -yq \
autotools-dev \
autoconf \
autoconf-archive \
build-essential \
curl \
pkg-config

RUN set -o pipefail \
&& curl https://ftp.gnu.org/gnu/autoconf/autoconf-${AUTOCONF_VERSION}.tar.gz | tar -zxf - \
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
RUN curl https://ftp.gnu.org/gnu/autoconf/autoconf-${AUTOCONF_VERSION}.tar.gz | tar -zxf - \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it not work with pipefail?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested, yes.
https://askubuntu.com/questions/886537/set-e-o-pipefail-not-working-on-bash-script-on-ubuntu-16

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: b200e7a

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: b200e7a

Elegant!

&& cd autoconf-${AUTOCONF_VERSION} \
&& ./configure --prefix=/usr/local \
&& make \
&& make install
RUN set -o pipefail \
&& curl https://ftp.gnu.org/gnu/automake/automake-${AUTOMAKE_VERSION}.tar.gz | tar -xzf - \
RUN curl https://ftp.gnu.org/gnu/automake/automake-${AUTOMAKE_VERSION}.tar.gz | tar -xzf - \
&& cd automake-${AUTOMAKE_VERSION} \
&& ./configure --prefix=/usr/local \
&& make \
&& make install
RUN set -o pipefail \
&& curl https://ftp.gnu.org/gnu/autoconf-archive/autoconf-archive-${AUTOCONF_ARCHIVE_VERSION}.tar.xz | xz -cd - | tar -xf - \
RUN curl https://ftp.gnu.org/gnu/autoconf-archive/autoconf-archive-${AUTOCONF_ARCHIVE_VERSION}.tar.xz | xz -cd - | tar -xf - \
&& cd autoconf-archive-${AUTOCONF_ARCHIVE_VERSION} \
&& ./configure --prefix=/usr/local \
&& make \
&& make install

# https://stackoverflow.com/questions/8811381/possibly-undefined-macro-ac-msg-error/49103418#49103418
RUN set -o pipefail \
&& cp /usr/local/share/aclocal/*.m4 /usr/share/aclocal \
RUN cp /usr/local/share/aclocal/*.m4 /usr/share/aclocal \
&& cp /usr/share/aclocal/*.m4 /usr/local/share/aclocal

VOLUME /src
Expand Down