Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Set dynamic run-name to distinguish package name #16

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 8, 2024

Screenshot from 2024-10-08 09-18-23

Currently, no way to distinguish which packages were released. It will help to distinguish job lists.

@corona10
Copy link
Member Author

corona10 commented Oct 8, 2024

cc @trallard

@corona10 corona10 changed the title .github: Set dynamc run-name to distinguish package name .github: Set dynamic run-name to distinguish package name Oct 8, 2024
@corona10
Copy link
Member Author

corona10 commented Oct 8, 2024

@brettcannon I would like to recommend releasing new devcontainer image after this PR is merged :)

@brettcannon
Copy link
Member

@brettcannon I would like to recommend releasing new devcontainer image after this PR is merged :)

Did you want me to do it or did you want to go ahead and trigger (I honestly forgot it was a manual trigger 😅).

@corona10 corona10 merged commit 5c70ea8 into python:main Oct 9, 2024
4 checks passed
@corona10
Copy link
Member Author

corona10 commented Oct 9, 2024

Did you want me to do it or did you want to go ahead and trigger (I honestly forgot it was a manual trigger 😅).

Well, I am not an expert on devcontainer, so I think that you should trigger from now on, including replacing the image at CPython repo :)
https://github.com/python/cpython/blob/14b44c58e195c4cdee6594a4aacf8bf95b19fcd7/.devcontainer/devcontainer.json#L2

@brettcannon
Copy link
Member

I think that you should trigger from now on, including replacing the image at CPython repo :)

I had thought you had set it to the latest label so it wouldn't need updating, so I guess I have something to update regardless. 😁

@corona10
Copy link
Member Author

corona10 commented Oct 9, 2024

I had thought you had set it to the latest label so it wouldn't need updating, so I guess I have something to update regardless. 😁

I was not sure about this :) If you think that it will be safe please go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants