Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch for ax_c_float_words_bigendian.m4 to autoconf-archive #23

Merged

Conversation

erlend-aasland
Copy link
Collaborator

No description provided.

@erlend-aasland
Copy link
Collaborator Author

@corona10 corona10 self-assigned this Oct 16, 2024
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland
Nit comment:
If we have to vendor more custom patch, it might good to have own directory under autoconf, (e.g autoconf/diff)

@corona10 corona10 assigned erlend-aasland and unassigned corona10 Oct 16, 2024
@corona10
Copy link
Member

Feel free to merge this PR and publish new release when you want! through https://github.com/python/cpython-devcontainers/actions/workflows/release.yml

@erlend-aasland
Copy link
Collaborator Author

@erlend-aasland Nit comment: If we have to vendor more custom patch, it might good to have own directory under autoconf, (e.g autoconf/diff)

Yes, I thought about that, but I do not anticipate, nor hope, that there will be many patches :) If another patch is needed, let's introduce a more formal system for maintaining them.

@erlend-aasland erlend-aasland merged commit d5e7029 into python:main Oct 16, 2024
4 checks passed
@erlend-aasland erlend-aasland deleted the ax-c-float-words-bigendian branch October 16, 2024 07:26
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch autoconf-archive with an updated variant of AX_C_FLOAT_WORDS_BIGENDIAN
2 participants