Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-22: Amend float detection patch to use private Autoconf variables #30

Closed

Conversation

erlend-aasland
Copy link
Collaborator

No description provided.

@erlend-aasland
Copy link
Collaborator Author

erlend-aasland commented Oct 20, 2024

@damelang: I think this is a safer choice; what do you think of upstreaming this amendment?

@corona10
Copy link
Member

Hmm by the way, please take a look at this issue too: #29
Since we already upgrade the autoconf image to 24.04, we may need to modify related CI code or should be fixed from this repo side.

@erlend-aasland
Copy link
Collaborator Author

Thanks for the review, Donghee. I'll give Dan a chance to chime in before landing this.

@erlend-aasland
Copy link
Collaborator Author

Actually, I don't think we should do this; most macros in autoconf-archive use EXEEXT and not ac_exeext. Perhaps a workaround in configure.ac is the best solution after all.

@erlend-aasland erlend-aasland marked this pull request as draft October 21, 2024 08:17
@erlend-aasland
Copy link
Collaborator Author

[...] Perhaps a workaround in configure.ac is the best solution after all.

See:

@erlend-aasland erlend-aasland deleted the amend-float-detection branch October 25, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch autoconf-archive with an updated variant of AX_C_FLOAT_WORDS_BIGENDIAN
2 participants