-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable skipped test_zlib tests on s390x hardware acceleration #125041
Labels
tests
Tests in the Lib/test dir
Comments
encukou
added a commit
to encukou/cpython
that referenced
this issue
Oct 7, 2024
…king the compressed bytes
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Oct 15, 2024
…king the compressed bytes (pythonGH-125042) (cherry picked from commit cc5a225) Co-authored-by: Petr Viktorin <encukou@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Oct 15, 2024
…king the compressed bytes (pythonGH-125042) (cherry picked from commit cc5a225) Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou
added a commit
that referenced
this issue
Oct 16, 2024
encukou
added a commit
to encukou/cpython
that referenced
this issue
Oct 16, 2024
…king the compressed bytes (python#125042) (cherry picked from commit cc5a225)
encukou
added a commit
to encukou/cpython
that referenced
this issue
Oct 16, 2024
…, skip checking the compressed bytes (pythonGH-125042) This backports two commits: - pythonGH-31096 skipped the tests unconditionally - pythonGH-125042 skips only the possibly-failing assertion (cherry picked from commit cc5a225)
encukou
added a commit
to encukou/cpython
that referenced
this issue
Oct 16, 2024
…ration, skip checking the compressed bytes (pythonGH-125042) This backports two commits: - pythonGH-31096 skipped the tests unconditionally - pythonGH-125042 skips only the possibly-failing assertion (cherry picked from commit d522856) Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou
added a commit
that referenced
this issue
Oct 16, 2024
pablogsal
pushed a commit
that referenced
this issue
Oct 22, 2024
pablogsal
pushed a commit
that referenced
this issue
Oct 22, 2024
…p checking the compressed bytes (GH-125042) (#125585) gh-125041: gh-90781: test_zlib: For s390x HW acceleration, skip checking the compressed bytes (GH-125042) This backports two commits: - GH-31096 skipped the tests unconditionally - GH-125042 skips only the possibly-failing assertion (cherry picked from commit cc5a225)
ambv
pushed a commit
that referenced
this issue
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some variants of the s390x platform have instructions for hardware-accelerated deflate compression. With HW acceleration, compressed byte stream can be different from the software implementation in zlib. (It still decompresses to the original of course.)
The zlib-ng library can be built to use this, and CPython can be built with zlib-ng.
In 2022 (#90781, GH-31096), two tests that failed on s390x were unconditionally skipped. IMO, it would be better if we only skip checking the compressed stream, but do check the round-trip result.
Testing should be a bit easier now that a buildbot worker has the HW-accelerated zlib.
In #107535, the
skip_on_s390x
variable was separated from the comment that explains it.I propose to name the skip condition
HW_ACCELERATED
rather thanskip_on_s390x
-- theoretically, other platforms might need this in the future.Linked PRs
The text was updated successfully, but these errors were encountered: