Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] gh-109218: Refactor tests for the complex() constructor (GH-119635) #119796

Merged
merged 1 commit into from
May 30, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 30, 2024

  • Share common classes.
  • Use exactly representable floats and exact tests.
  • Check the sign of zero components.
  • Remove duplicated tests (mostly left after merging int and long).
  • Reorder tests in more consistent way.
  • Test more error messages.
  • Add tests for missed cases.
    (cherry picked from commit bf098d4)

Co-authored-by: Serhiy Storchaka storchaka@gmail.com

…GH-119635)

* Share common classes.
* Use exactly representable floats and exact tests.
* Check the sign of zero components.
* Remove duplicated tests (mostly left after merging int and long).
* Reorder tests in more consistent way.
* Test more error messages.
* Add tests for missed cases.
(cherry picked from commit bf098d4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels May 30, 2024
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) May 30, 2024 17:41
@serhiy-storchaka serhiy-storchaka merged commit 2e31e56 into python:3.12 May 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants