Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121528: Fix the process crash when load extension when it's compiled with low version of the python. #121550

Closed
wants to merge 5 commits into from
Closed

gh-121528: Fix the process crash when load extension when it's compiled with low version of the python. #121550

wants to merge 5 commits into from

Conversation

Zheaoli
Copy link
Contributor

@Zheaoli Zheaoli commented Jul 9, 2024 •
edited by bedevere-app bot
Loading

@Zheaoli Zheaoli changed the title gh121528: Fix the process crash when load extension when it's compiled with low version of the python. gh-121528: Fix the process crash when load extension when it's compiled with low version of the python. Jul 9, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jul 9, 2024
Closed
ZeroIntensity
ZeroIntensity requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this PR fixes #121528

Include/internal/pycore_object.h Outdated Show resolved Hide resolved
@ZeroIntensity
Copy link
Member

@Eclips4 Can you add the 3.13 backport label?

@Eclips4 Eclips4 added the needs backport to 3.13 bugs and security fixes label Jul 10, 2024
@Eclips4
Copy link
Member

Eclips4 commented Jul 10, 2024

cc @mgorny can you confirm that this patch fixes the issue?

@mgorny
Copy link
Contributor

mgorny commented Jul 10, 2024

I can confirm that rustworkx no longer crashes with this patch applied.

Zheaoli and others added 2 commits July 10, 2024 20:10
@Zheaoli @ZeroIntensity
Update Misc/NEWS.d/next/Core_and_Builtins/2024-07-10-03-13-19.gh-issu…
194a0e0 
…e-121528._Bo7rw.rst

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@Zheaoli @ZeroIntensity
Update Misc/NEWS.d/next/Core_and_Builtins/2024-07-10-03-13-19.gh-issu…
74478b9 
…e-121528._Bo7rw.rst

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@Zheaoli
Copy link
Contributor Author

Zheaoli commented Jul 10, 2024 •
edited
Loading

@ZeroIntensity Thanks for the nits!

ZeroIntensity
ZeroIntensity approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM.

@Zheaoli Zheaoli closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees
No one assigned
Labels
awaiting core review needs backport to 3.13 bugs and security fixes
Projects
None yet
Milestone
No milestone
4 participants
@Zheaoli @ZeroIntensity @Eclips4 @mgorny