Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-122544: Change OS image in GitHub Actions to ubuntu-24.04 #122566

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

Damien-Chen
Copy link
Contributor

@Damien-Chen Damien-Chen commented Aug 1, 2024

Change base OS image in Github Actions from ubuntu-22.04 to ubuntu-24.04

@bedevere-app
Copy link

bedevere-app bot commented Aug 1, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@hugovk hugovk changed the title gh-122544: Change OS image in github workflow to ubuntu-24.04 gh-122544: Change OS image in GitHub Actions to ubuntu-24.04 Aug 2, 2024
@AA-Turner
Copy link
Member

Failing due to Unable to locate package libmpdec-dev, as the libmpdec-dev package does not appear in Ubuntu 24.04 LTS. According to this comment, the removal is intentional as it is no longer needed, see the debian mailing list post.

@Damien-Chen are you able to test this please?

A

@Damien-Chen
Copy link
Contributor Author

Failing due to Unable to locate package libmpdec-dev, as the libmpdec-dev package does not appear in Ubuntu 24.04 LTS. According to this comment, the removal is intentional as it is no longer needed, see the debian mailing list post.

@Damien-Chen are you able to test this please?

A

Sure!. No problem!

@AA-Turner
Copy link
Member

The regen-all check is failing, I assume something changed between LTS versions -- can you run make regen-all on 24.04 and push that?

A

@Damien-Chen
Copy link
Contributor Author

The regen-all check is failing, I assume something changed between LTS versions -- can you run make regen-all on 24.04 and push that?

A

Let me check if I can test it locally on my WSL2 ubuntu-24.04 or use another local machine to install ubuntu-24.04. Or if I can trigger all pipline on my fork repo so that I I don’t have to confirm the result every time I commit to this PR.

@Damien-Chen
Copy link
Contributor Author

Damien-Chen commented Aug 3, 2024

The regen-all check is failing, I assume something changed between LTS versions -- can you run make regen-all on 24.04 and push that?

A

It means that adding make regen-all before git add -u like the below image show?

  - name: Check for changes
    run: |
      make regen-all
      git add -u
      changes=$(git status --porcelain)

@Damien-Chen
Copy link
Contributor Author

It seems same error, I run on my forked repo in this

@AA-Turner
Copy link
Member

Sorry, I meant you need to run make regen-all locally and commit the output of that to your branch.

@Damien-Chen
Copy link
Contributor Author

Sorry, I meant you need to run make regen-all locally and commit the output of that to your branch.

It seems that the below three file cause error in ubuntu-24.04
aclocal.m4, config.guess, configure.

I test it in several method. First is run make regen-all on my local ubuntun-24.04 machine, and convert the whole output into a script, and then execute it before running Check for changes test but it fails.
Then I copy the above three mention file generated in ubuntu-24.04, and overwrite the original three file that in ubuntu-22.04 and it seems pass the check.

Maybe there are some modification between ubuntu-22.04 and ubuntu-24.04 cause the above mentioned three file different ?

The whole process and result were conduct in my fork repo here

ubuntu-24.04output.txt

And the attached file is the output of running make regen-all in ubuntu-24.04.

@Damien-Chen
Copy link
Contributor Author

For ubuntu-24.04, these three file aclocal.m4, config.guess, configure are different than ubuntu-22.04. Maybe we should update these file together.

@hugovk
Copy link
Member

hugovk commented Sep 23, 2024

(Updating branch to re-trigger CLA bot, which got stuck a few days ago.)

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, CI changes look good to me. I'd like someone else (@corona10? @erlend-aasland?) to review the configure + libmpdec-dev changes.

@hugovk
Copy link
Member

hugovk commented Oct 10, 2024

@Damien-Chen Please could you resolve the conflicts?

@erlend-aasland @corona10 Please could you check the configure + libmpdec-dev changes here?

We'll also need to upgrade doctest soon (see #125236), but that can be a separate PR.

@erlend-aasland
Copy link
Contributor

I'll check it later today, when I'm back on my laptop.

@Damien-Chen
Copy link
Contributor Author

Resolved conflict.

@Damien-Chen
Copy link
Contributor Author

Should we merge this as early as possible?

@AA-Turner
Copy link
Member

There's no rush to merge this, it is currently blocked on review of the autoconf / configure changes. Most likely we will need to co-ordinate updating e.g. the docker images to Ubuntu 24 too.

cc @corona10

A

@erlend-aasland erlend-aasland enabled auto-merge (squash) November 5, 2024 23:11
@erlend-aasland erlend-aasland linked an issue Nov 5, 2024 that may be closed by this pull request
@erlend-aasland
Copy link
Contributor

@hugovk, I guess we want to backport this to 3.13 and 3.12.

@erlend-aasland erlend-aasland merged commit fc233f4 into python:main Nov 5, 2024
37 checks passed
@erlend-aasland
Copy link
Contributor

Thanks, @Damien-Chen, for the PR (hope you don't mind I regenerated configure for you), and thanks you all for the review.

@hugovk hugovk added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 6, 2024
@miss-islington-app

This comment was marked as outdated.

@miss-islington-app

This comment was marked as outdated.

@miss-islington-app
Copy link

Sorry, @Damien-Chen and @erlend-aasland, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fc233f46d3761b4e808be2c44fda0b843179004e 3.12

@miss-islington-app
Copy link

Sorry, @Damien-Chen and @erlend-aasland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fc233f46d3761b4e808be2c44fda0b843179004e 3.13

@erlend-aasland
Copy link
Contributor

@Damien-Chen, can you create the backports? See the devguide for details.

@Damien-Chen
Copy link
Contributor Author

Sure, I will take some time on it.

Damien-Chen added a commit to Damien-Chen/cpython that referenced this pull request Nov 9, 2024
Damien-Chen added a commit to Damien-Chen/cpython that referenced this pull request Nov 9, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 9, 2024

GH-126619 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 9, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 9, 2024

GH-126621 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 9, 2024
ambv added a commit that referenced this pull request Nov 22, 2024
@Damien-Chen Damien-Chen deleted the build-ubuntu-24.04 branch November 24, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change base OS image to Ubuntu-24.04 in CI testing
5 participants