-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-122544: Change OS image in GitHub Actions to ubuntu-24.04 #122566
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Failing due to @Damien-Chen are you able to test this please? A |
Sure!. No problem! |
The A |
Let me check if I can test it locally on my WSL2 |
It means that adding
|
It seems same error, I run on my forked repo in this |
Sorry, I meant you need to run |
It seems that the below three file cause error in I test it in several method. First is run Maybe there are some modification between The whole process and result were conduct in my fork repo here And the attached file is the output of running |
For |
144781b
to
05cc76b
Compare
(Updating branch to re-trigger CLA bot, which got stuck a few days ago.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, CI changes look good to me. I'd like someone else (@corona10? @erlend-aasland?) to review the configure + libmpdec-dev changes.
@Damien-Chen Please could you resolve the conflicts? @erlend-aasland @corona10 Please could you check the configure + libmpdec-dev changes here? We'll also need to upgrade doctest soon (see #125236), but that can be a separate PR. |
I'll check it later today, when I'm back on my laptop. |
cd4be03
to
753387e
Compare
Resolved conflict. |
Should we merge this as early as possible? |
There's no rush to merge this, it is currently blocked on review of the autoconf / configure changes. Most likely we will need to co-ordinate updating e.g. the docker images to Ubuntu 24 too. cc @corona10 A |
fa72459
to
6e14b32
Compare
@hugovk, I guess we want to backport this to 3.13 and 3.12. |
Thanks, @Damien-Chen, for the PR (hope you don't mind I regenerated |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, @Damien-Chen and @erlend-aasland, I could not cleanly backport this to
|
Sorry, @Damien-Chen and @erlend-aasland, I could not cleanly backport this to
|
@Damien-Chen, can you create the backports? See the devguide for details. |
Sure, I will take some time on it. |
….04 (python#122566) (cherry picked from commit fc233f4)
GH-126619 is a backport of this pull request to the 3.13 branch. |
GH-126621 is a backport of this pull request to the 3.12 branch. |
Change base OS image in Github Actions from
ubuntu-22.04
toubuntu-24.04