Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-122868: Add more lower bounds for sphinxcontrib dependencies #122891

Merged
merged 2 commits into from
Aug 10, 2024
Merged

gh-122868: Add more lower bounds for sphinxcontrib dependencies #122891

merged 2 commits into from
Aug 10, 2024

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Aug 10, 2024 •
edited by github-actions bot
Loading

Replicates the lower bounds at sphinx-doc/sphinx#12756

Second time lucky?

A

📚 Documentation preview 📚: https://cpython-previews--122891.org.readthedocs.build/

@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Aug 10, 2024
@AA-Turner AA-Turner requested a review from hugovk August 10, 2024 20:24
@bedevere-app bedevere-app bot mentioned this pull request Aug 10, 2024
Closed
hugovk
hugovk approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🤞

Was thinking, shall we also increase the upper bounds form minor to major? For example, <2.2 -> <3?

hugovk
hugovk approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AA-Turner AA-Turner enabled auto-merge (squash) August 10, 2024 20:41
@AA-Turner AA-Turner merged commit 0959142 into python:main Aug 10, 2024
23 checks passed
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2024
@AA-Turner @miss-islington
pythongh-122868: Add more lower bounds for sphinxcontrib dependencies (…
78e9a3f 
…pythonGH-122891)

(cherry picked from commit 0959142)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 10, 2024

GH-122893 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 10, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2024
@AA-Turner @miss-islington
pythongh-122868: Add more lower bounds for sphinxcontrib dependencies (…
3685735 
…pythonGH-122891)

(cherry picked from commit 0959142)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 10, 2024

GH-122894 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Aug 10, 2024
AA-Turner added a commit that referenced this pull request Aug 10, 2024
@miss-islington @AA-Turner
[3.12] gh-122868: Add more lower bounds for sphinxcontrib dependencies (
d70c399 
GH-122891) (#122894)

gh-122868: Add more lower bounds for sphinxcontrib dependencies (GH-122891)
(cherry picked from commit 0959142)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@AA-Turner AA-Turner deleted the docs/constraints branch August 10, 2024 21:05
AA-Turner added a commit that referenced this pull request Aug 10, 2024
@miss-islington @AA-Turner
[3.13] gh-122868: Add more lower bounds for sphinxcontrib dependencies (
b62f8c9 
GH-122891) (#122893)

gh-122868: Add more lower bounds for sphinxcontrib dependencies (GH-122891)
(cherry picked from commit 0959142)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@AA-Turner @blhsing
pythongh-122868: Add more lower bounds for sphinxcontrib dependencies (…
0fce01a 
…python#122891)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AA-Turner @hugovk