-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-124502: Add PyUnicode_Equal() function #124504
Conversation
@picnixz @rruuaanng @ZeroIntensity: I addressed your comments. Please review the updated PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final nitpick but you can ignore it (I don't know whether it's that useful).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM.
Maybe you are right, But you can consider my suggestion. |
I created capi-workgroup/decisions#43 issue in the C API Working Group. |
I wrote a microbenchmark comparing equal strings of 10 characters: Results on Fedora 40 with CPU isolation:
Proposed public Private |
Microbenchmark on comparison of inequal strings of 10 characters, only the last character is different.
|
The C API Working Group approved the API. |
Merged. Thanks for reviews @picnixz and @ZeroIntensity. |
📚 Documentation preview 📚: https://cpython-previews--124504.org.readthedocs.build/