gh-124927: Fix conversion issue between coordinates and position in REPL #125001
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Misc/NEWS.d/next/Library/2024-10-05-11-54-31.gh-issue-124927.OOOlif.rst
Outdated
Show resolved
Hide resolved
|
Test failures are related to the change. |
ImFeH2
force-pushed
the
non-printing-char
branch
from
1819ec0 to
dc3906a
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All tests have passed, what should I do next? |
Actually the tests were not executed (someone needed to approve the workflow which I did). So we'll just wait until they are indeed complete. |
Misc/NEWS.d/next/Library/2024-10-05-13-25-07.gh-issue-124927.uzNA32.rst
Outdated
Show resolved
Hide resolved
…zNA32.rst Co-authored-by: Miro Hrončok <miro@hroncok.cz>
ImFeH2
force-pushed
the
non-printing-char
branch
from
9386824 to
429c206
Compare
|
Hi @pablogsal, would you mind taking a look at this small PR when you have a chance? Thanks in advance! |
When encountering non printing characters, there will be 0 in self.screeninfo. Resulting in the setpos_from_xy function getting stuck in a dead loop when pressing the up/down keys, and pos2xy returns an incorrect value when the left/right keys.