-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-125522: Remove bare except in test_zlib.test_flushes #126321
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
cc: @corona10 |
@simple-is-great See the example of cpython/Lib/test/test__opcode.py Lines 15 to 17 in 914356f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One formatting nitpick, otherwise LGTM.
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @simple-is-great for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…gh-126321) (cherry picked from commit cfb1b2f) Co-authored-by: simple-is-great <103080930+simple-is-great@users.noreply.github.com>
…gh-126321) (cherry picked from commit cfb1b2f) Co-authored-by: simple-is-great <103080930+simple-is-great@users.noreply.github.com>
GH-126327 is a backport of this pull request to the 3.13 branch. |
GH-126328 is a backport of this pull request to the 3.12 branch. |
This is a simple rewrite of the test to avoid bare except and make the test's intention clearer.