gh-126317: Simplify stdlib code by using itertools.batched() #126323
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
@dongwooklee96 is the first-time contributor to the PyCon KR sprint today. |
| @@ -1049,14 +1048,11 @@ def _batch_appends(self, items, obj): | |||
| write(APPENDS) | |||
| elif n: | |||
There was a problem hiding this comment.
This can be replaced with else, since batched() does not emit empty batches.
| @@ -1035,12 +1035,11 @@ def _batch_appends(self, items, obj): | |||
|
|
|||
| it = iter(items) | |||
There was a problem hiding this comment.
it is no longer needed. items can be used directly.
| @@ -1087,12 +1083,11 @@ def _batch_setitems(self, items, obj): | |||
| return | |||
|
|
|||
| it = iter(items) | |||
| @@ -1101,17 +1096,14 @@ def _batch_setitems(self, items, obj): | |||
| raise | |||
| write(SETITEMS) | |||
| elif n: | |||
| @@ -1125,8 +1117,7 @@ def save_set(self, obj): | |||
| self.memoize(obj) | |||
|
|
|||
| it = iter(obj) | |||
| n = len(batch) | ||
| if n > 0: |
There was a problem hiding this comment.
This is no longer needed.
| n = len(tmp) | ||
| for batch in batched(it, self._BATCHSIZE): | ||
| n = len(batch) | ||
| if n > 1: |
There was a problem hiding this comment.
You can inline n which is only used one time. Also, it would be safer to write the condition as len(batch) != 1.
itertools.batched()#126317