Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-123925: Fix building curses on platforms without libncursesw #128405

Merged
merged 1 commit into from
Jan 2, 2025
Merged

gh-123925: Fix building curses on platforms without libncursesw #128405

merged 1 commit into from
Jan 2, 2025

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 2, 2025 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jan 2, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 2, 2025
Closed
erlend-aasland
erlend-aasland approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this problem also exists on Debian. This patch looks good to me.

@serhiy-storchaka serhiy-storchaka merged commit 8d16919 into python:main Jan 2, 2025
51 checks passed
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@serhiy-storchaka serhiy-storchaka deleted the curses-without-libncursesw branch January 2, 2025 11:38
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2025
@serhiy-storchaka @miss-islington
pythongh-123925: Fix building curses on platforms without libncursesw (…
7f23541 
…pythonGH-128405)

(cherry picked from commit 8d16919)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 2, 2025

GH-128407 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2025
@serhiy-storchaka @miss-islington
pythongh-123925: Fix building curses on platforms without libncursesw (…
3305bf8 
…pythonGH-128405)

(cherry picked from commit 8d16919)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 2, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 2, 2025

GH-128408 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 2, 2025
serhiy-storchaka added a commit that referenced this pull request Jan 2, 2025
@miss-islington @serhiy-storchaka
[3.12] gh-123925: Fix building curses on platforms without libncursesw (
84c8843 
GH-128405) (GH-128408)

(cherry picked from commit 8d16919)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jan 2, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-123925: Fix building curses on platforms without libncursesw (
261a604 
GH-128405) (GH-128407)

(cherry picked from commit 8d16919)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@serhiy-storchaka @srinivasreddy
pythongh-123925: Fix building curses on platforms without libncursesw (…
59b195c 
…pythonGH-128405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @erlend-aasland