gh-128472: Add -skip-funcs to BOLT options to fix computed goto errors
#128511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
zanieb
commented
Jan 5, 2025
|
cc @aaupov You may be interested in this issue as the CPython use-case.. :) |
corona10
reviewed
Jan 5, 2025
| dnl At least LLVM 19.x doesn't support computed gotos in PIC compiled code. | ||
| dnl Exclude functions containing computed gotos. | ||
| dnl TODO this may be fixed in LLVM 20.x via https://github.com/llvm/llvm-project/pull/120267. | ||
| [-skip-funcs=_PyEval_EvalFrameDefault,sre_ucs1_match/1,sre_ucs2_match/1,sre_ucs4_match/1] |
There was a problem hiding this comment.
Now we have reasons to add CI to maintain this list actively.
corona10
approved these changes
Jan 7, 2025
zanieb
added
needs backport to 3.12
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 7, 2025
…to errors (pythongh-128511) * Add `-skip-funcs` to BOLT options to fix computed goto errors Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com> * NEWS --------- (cherry picked from commit 24b147a) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 7, 2025
…to errors (pythongh-128511) * Add `-skip-funcs` to BOLT options to fix computed goto errors Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com> * NEWS --------- (cherry picked from commit 24b147a) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
|
GH-128572 is a backport of this pull request to the 3.12 branch. |
|
GH-128573 is a backport of this pull request to the 3.13 branch. |
corona10
pushed a commit
that referenced
this pull request
Jan 7, 2025
…oto errors (gh-128511) (gh-128572) gh-128472: Add `-skip-funcs` to BOLT options to fix computed goto errors (gh-128511) * Add `-skip-funcs` to BOLT options to fix computed goto errors * NEWS --------- (cherry picked from commit 24b147a) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
corona10
pushed a commit
that referenced
this pull request
Jan 7, 2025
…oto errors (gh-128511) (#128573) gh-128472: Add `-skip-funcs` to BOLT options to fix computed goto errors (gh-128511) * Add `-skip-funcs` to BOLT options to fix computed goto errors * NEWS --------- (cherry picked from commit 24b147a) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…to errors (pythongh-128511) * Add `-skip-funcs` to BOLT options to fix computed goto errors Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com> * NEWS --------- Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch was originally authored as part of astral-sh/python-build-standalone#463
Makes use of the common options added in #128455
Closes #128472
Backport needed for #124948
--enabled-sharedon LLVM 19 with "unable to get new address" #128472