Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-89770: Implement PEP-678 - Exception notes #31317

Merged
merged 23 commits into from
Apr 16, 2022
Merged

gh-89770: Implement PEP-678 - Exception notes #31317

merged 23 commits into from
Apr 16, 2022

Commits on Feb 13, 2022

  1. PEP-678: exception notes are set by add_note(). __notes__ holds a tup… 

    …le of the assigned notes
    @iritkatriel
    iritkatriel committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    1555087 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. clear notes with del e.__notes__, remove replace arg and None note op… 

    …tion
    @iritkatriel
    iritkatriel committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    6a38688 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. do not create new tuple when __notes__ is accessed

    @iritkatriel
    iritkatriel committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    7bab63e View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. Revert "do not create new tuple when __notes__ is accessed" 

    This reverts commit 7bab63e.
    @iritkatriel
    iritkatriel committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    396b5f1 View commit details
    Browse the repository at this point in the history

  2. add __notes__ attribute in add_note. Traceback ignores it if it's not… 

    … a sequence of strings
    @iritkatriel
    iritkatriel committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    f518aa5 View commit details
    Browse the repository at this point in the history

  3. add in add_note a check that __notes__ is a list. Add the test. tweak… 

    … __notes__ doc.
    @iritkatriel
    iritkatriel committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    0438933 View commit details
    Browse the repository at this point in the history

  4. TypeError in add_note if __notes__ is not a list

    @iritkatriel
    iritkatriel committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    dcc93ef View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. if __notes__ is not sequence, print repr(__notes__). If note is not a… 

    … string, print str(note)
    @iritkatriel
    iritkatriel committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    614378e View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. simplify traceback code (no need to special case note which is a string)

    @iritkatriel
    iritkatriel committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    f240e71 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. shallow copy the notes in split(), if it's a sequence

    @iritkatriel
    iritkatriel committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    6786dbd View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. split() ignores notes if they are not a sequence

    @iritkatriel
    iritkatriel committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    bdd4e2a View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. typo in doc 

    Co-authored-by: Petr Viktorin <encukou@gmail.com>
    @iritkatriel @encukou
    iritkatriel and encukou authored Mar 28, 2022
    Configuration menu
    Copy the full SHA
    711e804 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. fix typo in test 

    Co-authored-by: Zac Hatfield-Dodds <zac.hatfield.dodds@gmail.com>
    @iritkatriel @Zac-HD
    iritkatriel and Zac-HD authored Apr 12, 2022
    Configuration menu
    Copy the full SHA
    e147f52 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into pep-678

    @iritkatriel
    iritkatriel committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    622ca51 View commit details
    Browse the repository at this point in the history

  3. 📜🤖 Added by blurb_it.

    @blurb-it
    blurb-it[bot] authored Apr 12, 2022
    Configuration menu
    Copy the full SHA
    404f80d View commit details
    Browse the repository at this point in the history

  4. update test_traceback

    @iritkatriel
    iritkatriel committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    c014ad8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into pep-678

    @iritkatriel
    iritkatriel authored Apr 12, 2022
    Configuration menu
    Copy the full SHA
    47bfcdc View commit details
    Browse the repository at this point in the history

  6. update whatnew

    @iritkatriel
    iritkatriel committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    2ae22e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. METH_VARARGS --> METH_O

    @iritkatriel
    iritkatriel committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    95be670 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pep-678

    @iritkatriel
    iritkatriel authored Apr 14, 2022
    Configuration menu
    Copy the full SHA
    520efd1 View commit details
    Browse the repository at this point in the history

  3. add_note no longer has a replace kwarg

    @iritkatriel
    iritkatriel authored Apr 14, 2022
    Configuration menu
    Copy the full SHA
    a14e915 View commit details
    Browse the repository at this point in the history

  4. finish converting add_note to METH_O

    @iritkatriel
    iritkatriel committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    991e982 View commit details
    Browse the repository at this point in the history

  5. fix whitespace

    @iritkatriel
    iritkatriel committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    602b4c4 View commit details
    Browse the repository at this point in the history