Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated internals section of devguide by deleting the "Known Compiler-related Experiments" #1161

Merged
merged 8 commits into from
Oct 13, 2023

Conversation

Lincoln-developer
Copy link
Contributor

@Lincoln-developer Lincoln-developer commented Sep 11, 2023

Update internals section of devguide (issue #1159 )

The "Introducing New Bytecode" and "Known Compiler-related Experiments" do not belong in the compiler page. This change updates the compiler page by removing the "Introducing New Bytecode" and "Known Compiler-related Experiments from the compiler page.


📚 Documentation preview 📚: https://cpython-devguide--1161.org.readthedocs.build/

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Sep 11, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@Lincoln-developer Lincoln-developer changed the title Updated compiler page by deleting the Introducing New Bytecode Updated internals section of devguide by deleting the "Introducing New Bytecode" and "Known Compiler-related Experiments Sep 11, 2023
@AA-Turner
Copy link
Member

Mark noted that Introducing New Bytecode didn't belong on this page, rather to delete it entirely. Also note you've only removed the headings, not the body of the sections.

A

@Lincoln-developer Lincoln-developer changed the title Updated internals section of devguide by deleting the "Introducing New Bytecode" and "Known Compiler-related Experiments Updated internals section of devguide by deleting the "Introducing New Bytecode" and "Known Compiler-related gh-1159 Experiments Sep 26, 2023
@willingc willingc added the needs: PR update An update or rebase to an existing PR is needed. label Sep 29, 2023
@willingc willingc changed the title Updated internals section of devguide by deleting the "Introducing New Bytecode" and "Known Compiler-related gh-1159 Experiments Updated internals section of devguide by deleting the "Known Compiler-related Experiments" Oct 13, 2023
internals/compiler.rst Outdated Show resolved Hide resolved
internals/compiler.rst Outdated Show resolved Hide resolved
@willingc
Copy link
Collaborator

@Lincoln-developer I've updated your PR to only contain the deletion of the experiments section. I am doing some larger changes and will handle the bytecode section.

Congrats @Lincoln-developer on your first contribution to the devguide. 🎉

@willingc willingc merged commit 58e646e into python:main Oct 13, 2023
4 checks passed
@willingc willingc removed the needs: PR update An update or rebase to an existing PR is needed. label Oct 13, 2023
@Lincoln-developer
Copy link
Contributor Author

Thank you so much for this merge, I greatly appreciate @willingc .

@Lincoln-developer Lincoln-developer deleted the fix-issue-1159 branch October 13, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants