-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better support for packages with files outside site-packages #482
Conversation
The "weird tox issue" turns out to be an issue with pytest-perf, I think. I keep getting errors like:
when trying to run tests locally. |
You may want to report this issue to pytest-perf. I notice that That's one of the reasons I avoid the SSH protocol - because it tends to add noise like Trying to install it without the package name, I still get the same error:
Perhaps it's the case that the syntax pip expects is different than what git supplies. Indeed, the pip docs indicate that the URL should be If you want to work around the issue, you can use an https remote (e.g. Let me see if I can resolve the conflicts and get the tests running again. |
Thanks for this. Looks like it's pretty close. I'm a little concerned that this change introduces more reliance on the assumption that the package is on disk, when it could be in a zip file or elsewhere. |
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
I believe all the test failures were mypy related so I added a |
The issue with pytest-perf supporting SSH URLs was addressed in jaraco/pytest-perf#15. |
…and compatibility wrapper on Python 3.11 and earlier.
This reverts commit 4a3782d.
Released as v7.2.1. |
This should fix #455. I slightly modified the patch suggested by @jaraco in #455 (comment) so that we don't have to call
self.locate_file('').resolve()
forname
intext.splitlines()
, and fixed one type complaint I was getting locally.I'm not sure if the test I added works properly (which is one of the reasons I made this PR), because I'm running into a weird
tox
issue locally.