Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.13 #699

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Test Python 3.13 #699

merged 2 commits into from
Aug 8, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Aug 4, 2024

Pending CFFI support for 3.13, should be available in CFFI 1.17.0 soonish:

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (50e0ee5) to head (492ae1e).

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #699   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          357       357           
  Branches        29        29           
=========================================
  Hits           357       357           
Flag Coverage Δ
Python_3.11 100.00% <ø> (ø)
Python_3.12 100.00% <ø> (ø)
Python_3.13 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugovk
Copy link
Member Author

hugovk commented Aug 6, 2024

CFFI 1.17.0 is out, Python 3.13 now passes ✅

https://github.com/python-cffi/cffi/releases/tag/v1.17.0

@hugovk hugovk marked this pull request as ready for review August 6, 2024 18:29
Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a couple of comments to these two files to remind people to update both?

@hugovk
Copy link
Member Author

hugovk commented Aug 7, 2024

I don't think it's needed, but no strong opinion.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@hugovk hugovk merged commit 3a2ae95 into python:main Aug 8, 2024
7 checks passed
@hugovk hugovk deleted the add-3.13 branch August 8, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants