implement a detect_virt grain
#387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for things we may not want or be able to run when operating in a docker container.
Specific example is systemd-timesyncd, which refuses to start in a container:
```
[Unit]
Description=Network Time Synchronization
Documentation=man:systemd-timesyncd.service(8)
ConditionCapability=CAP_SYS_TIME
ConditionVirtualization=!container
DefaultDependencies=no
...
```
Note the `ConditionVirtualization` blocking.
Useful state might be something like:
```
systemd-timesyncd:
pkg:
- installed
service:
- enable: True
{% if grains["detect_virt"] not in ["docker"] %}
- running
{% endif %}
```
Which would _enable_ the service but not fail when it fails to start.
JacobCoffee
approved these changes
Jul 17, 2024
|
Don't forget to pull the latest changes on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for things we may not want or be able to run when operating in a docker container.
Specific example is systemd-timesyncd, which refuses to start in a container:
Note the
ConditionVirtualizationblocking.Useful state might be something like:
Which would enable the service but not fail when it fails to start.