Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bugs): properly reveal ip downstream #407

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Conversation

JacobCoffee
Copy link
Member

Description

  • Adds an include for fastly_params that will pull/inject real IPs for our nginx service

Closes

@JacobCoffee
Copy link
Member Author

logs (ignore x-forw-for, it was just debugging)

192.168.215.1 - - [25/Jul/2024:22:37:36 +0000] "GET / HTTP/1.1" 500 235 "-" "curl/8.6.0" 0.227 0.227 . X-Forwarded-For: "192.168.215.1, 127.0.0.1"

show the client ip intially now with current diff

@JacobCoffee
Copy link
Member Author

also removing that capture request header unless we need it because it seems to be working without it?

Jul 25 22:41:15 loadbalancer haproxy[23887]: 127.0.0.1:40476 [25/Jul/2024:22:41:15.756] main roundup-cpython/bugs.vagrant.psf.io 0/0/3/74/77 -/- 500 387 - - ---- 2/1/0/0/0 0/0 {curl/8.6.0|192.168.215.1} "GET / HTTP/1.1"
Jul 25 22:41:15 loadbalancer haproxy[23887]: 192.168.215.1:64664 [25/Jul/2024:22:41:15.755] tls:~ tls:/default 0/0/0/77/77 500 493 - - ---- 1/1/0/0/0 0/0 {curl/8.6.0|} "GET / HTTP/2.0"

192.168.215.1 - - [25/Jul/2024:22:41:12 +0000] "GET / HTTP/1.1" 500 235 "-" "curl/8.6.0" 0.064 0.064 . X-Forwarded-For: "192.168.215.1, 127.0.0.1"
192.168.215.1 - - [25/Jul/2024:22:41:14 +0000] "GET / HTTP/1.1" 500 235 "-" "curl/8.6.0" 0.073 0.073 . X-Forwarded-For: "192.168.215.1, 127.0.0.1"
192.168.215.1 - - [25/Jul/2024:22:41:15 +0000] "GET / HTTP/1.1" 500 235 "-" "curl/8.6.0" 0.074 0.074 . X-Forwarded-For: "192.168.215.1, 127.0.0.1"

@JacobCoffee
Copy link
Member Author

last few commits were stripping out some things after testing, this seems to be the bare minimum changeset needed for what we might want

@JacobCoffee JacobCoffee changed the title fix(bugs): include fastly params for real ip fix(bugs): reveal ip downstream Jul 25, 2024
@JacobCoffee JacobCoffee changed the title fix(bugs): reveal ip downstream fix(bugs): properly reveal ip downstream Jul 25, 2024
@ewdurbin ewdurbin merged commit 27a2335 into main Jul 26, 2024
2 checks passed
Copy link
Contributor

Don't forget to pull the latest changes on salt.nyc1.psf.io!

@ewdurbin ewdurbin deleted the fix-rate-limiting-bugs-#368 branch July 26, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug nginx rate limiting for bugs role
2 participants