Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile menu not working #144

Closed
hugovk opened this issue Aug 5, 2023 · 1 comment
Closed

Mobile menu not working #144

hugovk opened this issue Aug 5, 2023 · 1 comment
Labels

Comments

@hugovk
Copy link
Member

hugovk commented Aug 5, 2023

Steps to reproduce:

  1. Open docs in mobile view
  2. Click the menu at the top left

Expected result: menu opens
Actual result: menu doesn't open

This is due to the mobile-nav container being placed inside the document div instead of outside and before:

image

This is caused by #141 which moved mobile-nav, cc @miketheman.

@hugovk
Copy link
Member Author

hugovk commented Aug 24, 2023

Fixed by reverting PR #141 in PR #146.

We'll need another fix for issue #130.

@hugovk hugovk closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant