Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make option to invert/modify colors for documentation pages #145

Closed
brandonardenwalli opened this issue Aug 14, 2023 · 5 comments
Closed

Comments

@brandonardenwalli
Copy link

Feature or enhancement

When reading the docs page in dark mode with night shift, some variables are invisible to see. For example in https://docs.python.org/3/c-api/intro.html#types, int, long, double and char* are impossible to read without highlighting the text. This looks to affect any other parts of docs with same coloring too, for example all texts typedef on https://docs.python.org/3/c-api/typeobj.html page are practically invisible.

Environment:

Enable dark mode for system/browser (black background), AND enable night shift. I think there are multiple ways to do so, for example Windows has built in night shift mode to enable screen to be more orange (basically make screen have less blue light). For easiest reproduction, download f.lux and set color to 1900K (or as low as possible). Look at page again, and all the dark blue text, for example the type and typedef texts, became invisible.

Pitch

The docs will be much more readable and improve accessibility for bigger audience if the text colors can be modified. I'm not sure how much work this would require, but can be happy to provide feedback. Alternatively, if making the docs text configurable by end user is too much work, just hard code a more friendly color that is readable with dark mode and night shift enabled.

Let me know if you want more information!

@hugovk hugovk transferred this issue from python/cpython Aug 14, 2023
@hugovk
Copy link
Member

hugovk commented Aug 14, 2023

(I've transferred this from https://github.com/python/cpython to https://github.com/python/python-docs-theme)

Thanks for the report!

This is a contrast bug, already fixed in #133 and released in https://github.com/python/python-docs-theme/releases/tag/2023.7, but we had to skip that release due to #144 / #141.

Let's revert #141 so we can make a new release.

@brandonardenwalli

This comment was marked as off-topic.

@hugovk

This comment was marked as off-topic.

@brandonardenwalli

This comment was marked as off-topic.

@hugovk
Copy link
Member

hugovk commented Oct 19, 2023

This has now been released and deployed, and the contrast is now improved. Thanks!

@hugovk hugovk closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants