Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let long code literals extend beyond the right side of the screen #139

Merged
merged 2 commits into from
Jul 30, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 27, 2023

@hugovk hugovk added the bug label Jul 27, 2023
@hugovk hugovk marked this pull request as ready for review July 27, 2023 11:47
@pradyunsg
Copy link
Member

pradyunsg commented Jul 27, 2023

In Furo, I went ahead and set break-word on the entire content container in pradyunsg/furo@c8b51d0

That makes it so that no regular text/markup, including really long one-word titles don't trigger a rewrap by default, would have an overflow beyond that element.

Do you think it's worth adopting a similar model here?

@hugovk
Copy link
Member Author

hugovk commented Jul 28, 2023

Yes, that sounds better, would you like to update this PR or create a new one?

@hugovk
Copy link
Member Author

hugovk commented Jul 30, 2023

Updated, how does this look?

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hugovk hugovk merged commit c98e976 into python:main Jul 30, 2023
6 checks passed
@hugovk hugovk deleted the mobile-wrap-long-code-literals branch July 30, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap lines of code to prevent empty horizontal scroll
3 participants