Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use correct block, enable built-in slash keypress" #146

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Aug 14, 2023

Reverts #141 due to #144.

@hugovk
Copy link
Member Author

hugovk commented Aug 14, 2023

Hmm, the CI is also failing when triggering a build on main:

https://github.com/python/python-docs-theme/actions/runs/5852175860/job/15864009165

Run python ./docsbuild-scripts/build_docs.py  --quick  --build-root ./build_root  --www-root ./www  --log-directory ./logs  --group $(id -g)  --skip-cache-invalidation  --theme $(pwd)  --language en  --branch origin/main
Error: Process completed with exit code 70.

Runs for 1m10s with no log output.

@hugovk
Copy link
Member Author

hugovk commented Aug 14, 2023

Ah right, running locally we get some logs:

Details
python ./docsbuild-scripts/build_docs.py --quick --build-root /tmp/build_root --www-root /tmp/www --log-directory /tmp/logs --group $(id -g) --skip-cache-invalidation --theme $(pwd) --language en --branch origin/main
INFO:Updating repository https://github.com/python/cpython.git in /private/tmp/build_root/cpython
INFO:Cloning https://github.com/python/cpython.git into /private/tmp/build_root/cpython
DEBUG:Run: 'git clone https://github.com/python/cpython.git /private/tmp/build_root/cpython'
DEBUG:Run: 'git clone https://github.com/python/cpython.git /private/tmp/build_root/cpython' OK
DEBUG:Run: 'git -C /private/tmp/build_root/cpython reset --hard origin/main --'
DEBUG:Run: 'git -C /private/tmp/build_root/cpython reset --hard origin/main --' OK
DEBUG:Run: '/Library/Frameworks/Python.framework/Versions/3.11/bin/python3 -m venv /private/tmp/build_root/venv-3.13'
DEBUG:Run: '/Library/Frameworks/Python.framework/Versions/3.11/bin/python3 -m venv /private/tmp/build_root/venv-3.13' OK
DEBUG:Run: '/private/tmp/build_root/venv-3.13/bin/python -m pip install /Users/hugo/github/python-docs-theme jieba -rrequirements.txt'
ERROR:Run: '/private/tmp/build_root/venv-3.13/bin/python -m pip install /Users/hugo/github/python-docs-theme jieba -rrequirements.txt' KO:
      Using cached sphinx-6.2.1-py3-none-any.whl (3.0 MB)
    Collecting blurb
      Using cached blurb-1.1.0-py3-none-any.whl (22 kB)
    Collecting sphinxext-opengraph==0.7.5
      Using cached sphinxext_opengraph-0.7.5-py3-none-any.whl (9.2 kB)
    ERROR: Cannot install python-docs-theme 2023.7 (from /Users/hugo/github/python-docs-theme) and python-docs-theme!=2023.7 and >=2023.3.1 because these package versions have conflicting dependencies.

    The conflict is caused by:
        The user requested python-docs-theme 2023.7 (from /Users/hugo/github/python-docs-theme)
        The user requested python-docs-theme!=2023.7 and >=2023.3.1

    To fix this you could try to:
    1. loosen the range of package versions you've specified
    2. remove package versions to allow pip attempt to solve the dependency conflict

    ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

    [notice] A new release of pip available: 22.3.1 -> 23.2.1
    [notice] To update, run: /private/tmp/build_root/venv-3.13/bin/python -m pip install --upgrade pip

ERROR:Exception while building en version 3.13
Traceback (most recent call last):
  File "/Users/hugo/github/python-docs-theme/./docsbuild-scripts/build_docs.py", line 709, in run
    self.build_venv()
  File "/Users/hugo/github/python-docs-theme/./docsbuild-scripts/build_docs.py", line 837, in build_venv
    run(
  File "/Users/hugo/github/python-docs-theme/./docsbuild-scripts/build_docs.py", line 331, in run
    result.check_returncode()
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/subprocess.py", line 502, in check_returncode
    raise CalledProcessError(self.returncode, self.args, self.stdout,
subprocess.CalledProcessError: Command '['/private/tmp/build_root/venv-3.13/bin/python', '-m', 'pip', 'install', '/Users/hugo/github/python-docs-theme', 'jieba', '-rrequirements.txt']' returned non-zero exit status 1.
INFO:Skipping sitemap generation (www root does not even exists).
INFO:Skipping 404 page generation (www root does not even exists).
INFO:Skipping robots.txt generation (www root does not even exists).

This is:

    ERROR: Cannot install python-docs-theme 2023.7 (from /Users/hugo/github/python-docs-theme) and python-docs-theme!=2023.7 and >=2023.3.1 because these package versions have conflicting dependencies.

    The conflict is caused by:
        The user requested python-docs-theme 2023.7 (from /Users/hugo/github/python-docs-theme)
        The user requested python-docs-theme!=2023.7 and >=2023.3.1

Caused by python/cpython#107666 (which is working around #144). So let's already bump the version here to allow the CI to build. ✅

@hugovk hugovk merged commit 9d3fc1f into main Aug 20, 2023
12 checks passed
@hugovk hugovk deleted the revert-141-miketheman/layout branch August 20, 2023 10:36
This was referenced Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants