-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Use correct block, enable built-in slash keypress" #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm, the CI is also failing when triggering a build on https://github.com/python/python-docs-theme/actions/runs/5852175860/job/15864009165
Runs for 1m10s with no log output. |
Ah right, running locally we get some logs: Details❯ python ./docsbuild-scripts/build_docs.py --quick --build-root /tmp/build_root --www-root /tmp/www --log-directory /tmp/logs --group $(id -g) --skip-cache-invalidation --theme $(pwd) --language en --branch origin/main
INFO:Updating repository https://github.com/python/cpython.git in /private/tmp/build_root/cpython
INFO:Cloning https://github.com/python/cpython.git into /private/tmp/build_root/cpython
DEBUG:Run: 'git clone https://github.com/python/cpython.git /private/tmp/build_root/cpython'
DEBUG:Run: 'git clone https://github.com/python/cpython.git /private/tmp/build_root/cpython' OK
DEBUG:Run: 'git -C /private/tmp/build_root/cpython reset --hard origin/main --'
DEBUG:Run: 'git -C /private/tmp/build_root/cpython reset --hard origin/main --' OK
DEBUG:Run: '/Library/Frameworks/Python.framework/Versions/3.11/bin/python3 -m venv /private/tmp/build_root/venv-3.13'
DEBUG:Run: '/Library/Frameworks/Python.framework/Versions/3.11/bin/python3 -m venv /private/tmp/build_root/venv-3.13' OK
DEBUG:Run: '/private/tmp/build_root/venv-3.13/bin/python -m pip install /Users/hugo/github/python-docs-theme jieba -rrequirements.txt'
ERROR:Run: '/private/tmp/build_root/venv-3.13/bin/python -m pip install /Users/hugo/github/python-docs-theme jieba -rrequirements.txt' KO:
Using cached sphinx-6.2.1-py3-none-any.whl (3.0 MB)
Collecting blurb
Using cached blurb-1.1.0-py3-none-any.whl (22 kB)
Collecting sphinxext-opengraph==0.7.5
Using cached sphinxext_opengraph-0.7.5-py3-none-any.whl (9.2 kB)
ERROR: Cannot install python-docs-theme 2023.7 (from /Users/hugo/github/python-docs-theme) and python-docs-theme!=2023.7 and >=2023.3.1 because these package versions have conflicting dependencies.
The conflict is caused by:
The user requested python-docs-theme 2023.7 (from /Users/hugo/github/python-docs-theme)
The user requested python-docs-theme!=2023.7 and >=2023.3.1
To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
[notice] A new release of pip available: 22.3.1 -> 23.2.1
[notice] To update, run: /private/tmp/build_root/venv-3.13/bin/python -m pip install --upgrade pip
ERROR:Exception while building en version 3.13
Traceback (most recent call last):
File "/Users/hugo/github/python-docs-theme/./docsbuild-scripts/build_docs.py", line 709, in run
self.build_venv()
File "/Users/hugo/github/python-docs-theme/./docsbuild-scripts/build_docs.py", line 837, in build_venv
run(
File "/Users/hugo/github/python-docs-theme/./docsbuild-scripts/build_docs.py", line 331, in run
result.check_returncode()
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/subprocess.py", line 502, in check_returncode
raise CalledProcessError(self.returncode, self.args, self.stdout,
subprocess.CalledProcessError: Command '['/private/tmp/build_root/venv-3.13/bin/python', '-m', 'pip', 'install', '/Users/hugo/github/python-docs-theme', 'jieba', '-rrequirements.txt']' returned non-zero exit status 1.
INFO:Skipping sitemap generation (www root does not even exists).
INFO:Skipping 404 page generation (www root does not even exists).
INFO:Skipping robots.txt generation (www root does not even exists). This is:
Caused by python/cpython#107666 (which is working around #144). So let's already bump the version here to allow the CI to build. ✅ |
AA-Turner
approved these changes
Aug 20, 2023
This was referenced Aug 24, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #141 due to #144.