Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode: Also give aside.topic a dark background #150

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Dark mode: Also give aside.topic a dark background #150

merged 1 commit into from
Aug 25, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Aug 24, 2023

Fixes #149.

PR #138 added nav.contents to places where div.note and div.topic were given a dark background.

This new one:

image

isn't any of those. Instead it's an aside.topic:

image

Let's give it a dark background too:

image

@hugovk hugovk mentioned this pull request Aug 24, 2023
Closed
@hugovk hugovk merged commit 3eb3746 into python:main Aug 25, 2023
6 checks passed
@hugovk hugovk deleted the dark-mode-aside-topic branch August 25, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

@m-aciek m-aciek m-aciek approved these changes

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrectly highlighted paragraph in dark theme
4 participants
@hugovk @AA-Turner @m-aciek @ezio-melotti