Issue #1701: Events page displays year for events scheduled to start or end at a future year #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvindera97
changed the title
alvindera97
changed the title
|
Good day @ewdurbin. Please could you review my pull request? Thank you. |
ferdnyc
reviewed
Sep 5, 2021
Passed variables to the time_tag template [time_tag.html] that checks if an event was scheduled to start or end with the current year.
More events are created to test particular scenarios of events especially events set to start or end at a future year.
…t Year The time tag now displays the year when an event will occur. This is only for events that have been scheduled to start or end in at a future year. The accompanying functional tests have also been included.
All test data concerning the provision of data to serve the functional tests have been moved to the functional test. As it improves readability. All other test data at test_views.py was reset to accommodate for the reduction in number of test data instances.
…plemented With Unit Tests
Since the current CI at the main branch does not support selenium [web driver] operations, the functional test which depends on selenium to run has been removed.
alvindera97
force-pushed
the
change-functional-test-to-unit-test
branch
2 times, most recently
from
77b59ed
to
1a3df45
Compare
alvindera97
force-pushed
the
change-functional-test-to-unit-test
branch
from
1a3df45
to
0ed1e92
Compare
* Fixed Issue#2190Now the Homepage code sample doesn't have syntax error * Another minor typo in the next line Co-authored-by: Eshaan <eshaan@pop-os.localdomain>
…hon#2233) * ignore Makefile .state folder * add test and docker_shell command to Makefile * Add command to create pycon vouchers for sponsors * Update sponsors/management/commands/create_pycon_vouchers_for_sponsors.py * Update sponsors/management/commands/create_pycon_vouchers_for_sponsors.py Co-authored-by: Ee Durbin <ewdurbin@gmail.com>
Bumps [django-sitetree](https://github.com/idlesign/django-sitetree) from 1.17.0 to 1.18.0. - [Changelog](https://github.com/idlesign/django-sitetree/blob/master/CHANGELOG) - [Commits](idlesign/django-sitetree@v1.17.0...v1.18.0) --- updated-dependencies: - dependency-name: django-sitetree dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lxml](https://github.com/lxml/lxml) from 4.9.2 to 5.2.2. - [Release notes](https://github.com/lxml/lxml/releases) - [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt) - [Commits](lxml/lxml@lxml-4.9.2...lxml-5.2.2) --- updated-dependencies: - dependency-name: lxml dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Passed variables to the time_tag template [time_tag.html] that checks if an event was scheduled to start or end with the current year.
More events are created to test particular scenarios of events especially events set to start or end at a future year.
…t Year The time tag now displays the year when an event will occur. This is only for events that have been scheduled to start or end in at a future year. The accompanying functional tests have also been included.
All test data concerning the provision of data to serve the functional tests have been moved to the functional test. As it improves readability. All other test data at test_views.py was reset to accommodate for the reduction in number of test data instances.
…plemented With Unit Tests
Since the current CI at the main branch does not support selenium [web driver] operations, the functional test which depends on selenium to run has been removed.
…est' into successfully_rebased_cfttut
Passed variables to the time_tag template [time_tag.html] that checks if an event was scheduled to start or end with the current year.
More events are created to test particular scenarios of events especially events set to start or end at a future year.
…t Year The time tag now displays the year when an event will occur. This is only for events that have been scheduled to start or end in at a future year. The accompanying functional tests have also been included.
All test data concerning the provision of data to serve the functional tests have been moved to the functional test. As it improves readability. All other test data at test_views.py was reset to accommodate for the reduction in number of test data instances.
…plemented With Unit Tests
Since the current CI at the main branch does not support selenium [web driver] operations, the functional test which depends on selenium to run has been removed.
…t Year The time tag now displays the year when an event will occur. This is only for events that have been scheduled to start or end in at a future year. The accompanying functional tests have also been included.
All test data concerning the provision of data to serve the functional tests have been moved to the functional test. As it improves readability. All other test data at test_views.py was reset to accommodate for the reduction in number of test data instances.
…plemented With Unit Tests
Since the current CI at the main branch does not support selenium [web driver] operations, the functional test which depends on selenium to run has been removed.
…ndera97/pythondotorg into successfully_rebased_cfttut
|
Hi everyone 👋🏾 A very warm greeting to you all and I would like to use this opportunity to say a big thank you for keeping Python's website functional all these years! It's been a very long time since I last worked on this pull request (essentially 4 years now).. I've been able to merge/rebase all updates since that time and confirmed that the tests pass and the feature still works. Just as a footnote, this PR resolves #1701. Thank you for you time and I hope a favourable response :). If there's anyone who would be free to take a look at what changes have been made and how they impact the source code, please feel free to leave comments and I will be able to respond to / hopefully address your comment. Best regards. |
|
I'm currently working on making a cleaner version of this pull request... I'll most probably move it to another PR, however I'll mention this pull request. |
|
I've set up the new pull request replacing this one here: #2500... I will now be closing this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR replacing #1713. The functional tests have been removed and logical/functional concerns have been replicated with unit tests that don't require selenium to run.
This is basically because of the CI Pipeline which makes no provision for installing selenium's web driver required by selenium to run the [headless] functional tests.
There is something that I would like to note:
— When I was running the unit tests, I found out that Django was somehow caching the results of the tests and so the subsequent test results I was getting were rather untrustworthy.
• I was able to get around this by adding a
tearDown()method to the relevant unit test class. ThistearDown()method basically clears the cache at the end of each test (cache.clear()) suggested herePlease feel free to ask any questions. This is basically my first shot at contributing to open source software.