Prioritise 64-bit downloads over 32-bit #2311
Conversation
|
Could the "embeddable package" ones also sort below the "installer" ones? That way the first Windows thing people see in list is our Recommended one. |
|
Updated to put those matching 
Older ones (see right column) have a different filename structure, so it doesn't match them: 
We could match something like |
|
I wonder how many people download the windows help file (whatever that is). it could be sorted lower, probably below the installers before embedded. regardless, this PR is good. lets ship it and iterate further later. |
|
Updated with an explicit preferred sort order for Windows files, how does this look? 
|
|
nice! |
|
@ewdurbin Please merge this. |
| windows_files = [] | ||
| other_files = [] | ||
| for preferred in ( | ||
| 'Windows installer (64-bit)', |
There was a problem hiding this comment.
Are these strings generated by code elsewhere in the codebase or manually input by Release Managers?
If it is manual input, this feels brittle and likely to cause confusion.
There was a problem hiding this comment.
They appear to be strings stored on the ReleaseFile model via the NameSlugModel mixin. I'm pretty iffy on handling this this way honestly.
There was a problem hiding this comment.
Yes, they're freeform strings, set by the script adding the ReleaseFile objects: https://github.com/python/release-tools/blob/master/add-to-pydotorg.py#L90.
There was a problem hiding this comment.
Before checking for the exact strings, I had something that checked for substrings like "(64-bit)", "(32-bit)" and "Windows embeddable package", see the old version at: dadd924 (#2311)
Would you prefer something like that? Or some other approach?
There was a problem hiding this comment.
IMHO having the strings is fine, if comments were added to reference this file from the other and vice-versa
|
I'm willing to help with whatever needs doing here, just let me know. |
Fixes #2194.
Before
http://0.0.0.0:8000/downloads/release/python-3107/
http://0.0.0.0:8000/downloads/windows/
After
http://0.0.0.0:8000/downloads/release/python-3107/
http://0.0.0.0:8000/downloads/windows/