Remove link to facebook and add LinkedIn in the Python.org socialize menu #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlcohen
force-pushed
the
issue-2325-remove-fb-link-add-linkedin-link
branch
from
9a47d32
to
7802d9a
Compare
|
Hmm, I'm not entirely sure what to do about the Read the Docs build failure.
Nothing in my PR touches the docs. Anyone know what the issue is? |
|
Don't worry about the RTD failure, it's started happening for all builds: https://readthedocs.org/projects/pythondotorg/builds/ Here's the fix: https://blog.readthedocs.com/migrate-configuration-v2/ And I've suggested an improved error message at RTD: readthedocs/readthedocs.org#10910 Edit: See #2328 to fix the RTD build. |
…menu Updated the socialize menu: - Removed Facebook link - Added Linkedin link Related issue: python#2325
mlcohen
force-pushed
the
issue-2325-remove-fb-link-add-linkedin-link
branch
from
7802d9a
to
71185cc
Compare
hugovk
approved these changes
Nov 21, 2023
|
I think this is ready for merge! 👍 |
|
superseded by #2367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the socialize menu:
Details
Note that the Linkedin icon SVG was taken from Wikipedia Commons. The official branded Linkedin icon is only offered as a PNG.
Resolves #2325
Before Update
After Update
(screenshot taken from localhost)