Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove broken Twitter widget #2329

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Remove broken Twitter widget #2329

merged 2 commits into from
Nov 21, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 20, 2023

Fixes #738.

The Twitter widget is broken, let's remove it:

image

https://www.python.org/about/gettingstarted/

@hugovk hugovk mentioned this pull request Nov 20, 2023
Closed
@hugovk
Copy link
Member Author

hugovk commented Nov 20, 2023

I edited style.css by hand.

Then I read the docs and installed the sass tools to run sass --compass --scss -I $(dirname $(dirname $(gem which susy))) --trace --watch sass/style.scss:sass/style.css, but it changed a lot more than what was removed here, so I didn't commit it.

@malemburg
Copy link
Member

LGTM. The ReadTheDocs failure should go away with #2328

willingc
willingc approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @hugovk

@malemburg malemburg merged commit f04b96f into python:main Nov 21, 2023
1 of 2 checks passed
@malemburg
Copy link
Member

I didn't know how to rerun the ReadTheDocs part of the checks, so just merged, since the main checks were fine.

@malemburg
Copy link
Member

Thanks, @hugovk

These changes will now need to be merged into the release branch to make them go live.

@malemburg
Copy link
Member

Let's wait for staging to pick up the changes first: https://staging.python.org/about/gettingstarted/

@malemburg
Copy link
Member

All good. Created #2330 to make this go live.

ewdurbin pushed a commit that referenced this pull request Nov 21, 2023
@malemburg @hugovk
Merge main into release (#2330)
f3eebba 
* Add config file for Read the Docs (#2328)

* Add config file for Read the Docs

* Remove comment

* Remove broken Twitter widget (#2329)

* Remove broken Twitter widget

* Remove broken Twitter widget

---------

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk hugovk deleted the rm-twitter-widget branch November 21, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tweet sidebar looks garish
3 participants
@hugovk @malemburg @willingc