Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new incorporation fields to form and sponsor model #2351

Merged
merged 12 commits into from
Jan 9, 2024

Conversation

jessiebelle
Copy link
Contributor

@jessiebelle jessiebelle commented Dec 24, 2023

addressing this issue
image

adding the following nullable fields to the sponsor model:

  • Country of incorporation
  • State of incorporation

new sponsor application form includes the new fields from the sponsor model

  • refactor of the new_sponsor_application_form.html to also accommodate editing sponsor information
  • updated tests to reflect that the correct form is used

@jessiebelle jessiebelle changed the title adding new fields to form and sponsor model add new incorporation fields to form and sponsor model Dec 24, 2023
Copy link
Member

@ewdurbin ewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only feedback is to group the new form fields a bit further away from the mailing address bits as it will likely confuse humans and form-fillers like password managers.

@ewdurbin
Copy link
Member

ewdurbin commented Jan 2, 2024

I updated the structure/order of the application form a bit with 4c32364

@jessiebelle could you update the edit form to match?

@ewdurbin ewdurbin merged commit 9b4dedd into main Jan 9, 2024
3 checks passed
@ewdurbin ewdurbin deleted the Issue-2126-add-country-and-state-of-incorporation branch January 9, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants