Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep GitHub Actions up to date with GitHub's Dependabot #2401

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

.github/dependabot.yml Outdated Show resolved Hide resolved
patterns:
- "*" # Group all Actions updates into a single larger pull request
schedule:
interval: weekly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monthly is less noisy:

Suggested change
interval: weekly
interval: monthly

Copy link
Contributor Author

@cclauss cclauss Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been three weeks...

GitHub Actions have very infrequent major version changes. For instance, setup-python has only had four major upgrades in its lifetime. Also, when they are upgraded, it often happens in batches. The pattern: * will consolidate all GHA updates into a single pull request to further reduce chattiness.

There is a tradeoff between supply chain security and chattiness. Given that we have a few GHAs that are updated rarely and usually in batches and we are using pattern: * to ensure that there will only ever be a single GHA upgrade PR at a time, my recommendation would have been to kick off this process in weekly mode. It is trivial to switch to monthly mode if we sense it becomes chatty. I doubt that it will.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the pattern: * approach should be used on the pip dependencies which are far more chatty than the GHA updates could ever be. https://github.com/python/pythondotorg/pulls/app%2Fdependabot

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
cclauss added a commit to cclauss/pythondotorg that referenced this pull request Mar 29, 2024
@cclauss cclauss mentioned this pull request Mar 29, 2024
@cclauss cclauss requested a review from hugovk March 29, 2024 20:30
ewdurbin pushed a commit that referenced this pull request Apr 18, 2024
.github/dependabot.yml Outdated Show resolved Hide resolved
@ewdurbin ewdurbin merged commit 69769b6 into python:main Apr 18, 2024
2 checks passed
@cclauss cclauss deleted the patch-1 branch April 18, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants