Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep GitHub Actions up to date with GitHub's Dependabot #2401

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Keep GitHub Actions up to date with GitHub's Dependabot #2401

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5afccaf
Keep GitHub Actions up to date with GitHub's Dependabot
cclauss Mar 11, 2024
348d317
Apply suggestions from code review
cclauss Mar 11, 2024
767e909
Update .github/dependabot.yml
ewdurbin Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,11 @@ updates:
- dependency-name: lxml
versions:
- 4.6.2
- package-ecosystem: github-actions
directory: /
cclauss marked this conversation as resolved.
Show resolved Hide resolved
groups:
github-actions:
patterns:
- "*" # Group all Actions updates into a single larger pull request
schedule:
interval: weekly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monthly is less noisy:

Suggested change
interval: weekly
interval: monthly

Copy link
Contributor Author

@cclauss cclauss Mar 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been three weeks...

GitHub Actions have very infrequent major version changes. For instance, setup-python has only had four major upgrades in its lifetime. Also, when they are upgraded, it often happens in batches. The pattern: * will consolidate all GHA updates into a single pull request to further reduce chattiness.

There is a tradeoff between supply chain security and chattiness. Given that we have a few GHAs that are updated rarely and usually in batches and we are using pattern: * to ensure that there will only ever be a single GHA upgrade PR at a time, my recommendation would have been to kick off this process in weekly mode. It is trivial to switch to monthly mode if we sense it becomes chatty. I doubt that it will.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the pattern: * approach should be used on the pip dependencies which are far more chatty than the GHA updates could ever be. https://github.com/python/pythondotorg/pulls/app%2Fdependabot