Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Improve low constrast of code blocks and links #2491

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jul 25, 2024

Closes #2446

I changed the code block color for the closest darker green that surpasses 4.5 - Firefox is now reporting it as 4.57.

I didn't want to change the link color for all links, so I just added a new rule to target links in tables only. Firefox now reports the new value as 4.56.

Let me know if it's ok like this!

@hugovk
Copy link
Member

hugovk commented Jul 25, 2024

I only checked the green so far, looks better.

Before:

image

After:

image

You know, I might be tempted to drop that rounded grey background box altogether, we don't have that sort of thing at https://docs.python.org/3/whatsnew/3.12.html, or keep the grey background but drop the shadow and rounder border radius.

image image

(Possibly also ditching the green?)

image image

@tomasr8
Copy link
Member Author

tomasr8 commented Jul 26, 2024

Could also decrease the padding.. It looks pretty big

@JacobCoffee
Copy link
Member

I think I like this the best out of the options:

image

but the current "After:" state is good, too.

Copy link
Member

@JacobCoffee JacobCoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your first contribution, @tomasr8 :)

@JacobCoffee JacobCoffee changed the title [a11y] Improve low constrast of code blocks and links fix(frontend): Improve low constrast of code blocks and links Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11y: Contrast of code formatting too low
3 participants