Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: add pr template, codeowners #2537

Merged
merged 2 commits into from
Sep 13, 2024
Merged

infra: add pr template, codeowners #2537

merged 2 commits into from
Sep 13, 2024

Conversation

JacobCoffee
Copy link
Member

What

Add this PR template
Add CODEOWNERS

Closes

@@ -0,0 +1,2 @@
# Notify @EWDurbin for all opened Issues and Pull Requests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name doesn't match list, no need to repeat names in comment, and it'll only assign for PRs (that touch code), not issues:

Suggested change
# Notify @EWDurbin for all opened Issues and Pull Requests
# Notify for all opened pull requests

@@ -0,0 +1,19 @@
<!--
By submitting this pull request, you agree to:
- follow the [PSF's Code of Conduct](https://www.python.org/psf/conduct/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direct link:

Suggested change
- follow the [PSF's Code of Conduct](https://www.python.org/psf/conduct/)
- follow the [PSF's Code of Conduct](https://policies.python.org/python.org/code-of-conduct/)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments were collapsed D: I missed them sorry 😞

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem :)

@JacobCoffee JacobCoffee merged commit 68fa4c1 into main Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants