Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: guid must be a full URL, use item link url #2588

Merged
merged 4 commits into from
Sep 18, 2024
Merged

fix: guid must be a full URL, use item link url #2588

merged 4 commits into from
Sep 18, 2024

Conversation

JacobCoffee
Copy link
Member

Description

  • Fixes guid by just using the link of the item

Closes

@JacobCoffee JacobCoffee enabled auto-merge (squash) September 18, 2024 20:33
ewdurbin
ewdurbin reviewed Sep 18, 2024
View reviewed changes
downloads/views.py Outdated Show resolved Hide resolved
@JacobCoffee @ewdurbin
Update downloads/views.py
aaa2941 
Co-authored-by: Ee Durbin <ewdurbin@gmail.com>
@ewdurbin
Copy link
Member

Docs say item_guid is optional, and if not provided the items link is used by default. Should we just remove the method override?

@JacobCoffee
Copy link
Member Author

@ewdurbin that would be okay, too. ill do that

@JacobCoffee JacobCoffee merged commit dc57cd2 into main Sep 18, 2024
6 checks passed
@ewdurbin ewdurbin deleted the fix-guid-validation-for-rss branch September 18, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewdurbin ewdurbin ewdurbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Downloads RSS feed doesnt fully validate
2 participants
@JacobCoffee @ewdurbin