Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add potential SBOMs to python.org #84

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

sethmlarson
Copy link
Collaborator

@sethmlarson sethmlarson commented Jan 17, 2024

Part of python/cpython#112302

Currently this code has no effect, however once SBOMs begin to be generated in #82 there will be additional files so we need to do something with them to avoid failing releases on "unexpected file"

This PR is a follow-up from python/pythondotorg#2359, so python.org now supports the field sbom_spdx2_file.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I was going to suggest some f-strings, but this is consistent with existing code.

We might benefit from adding some CI (in another PR), even if just some linting, it could help catch potential syntax errors and so on.

@sethmlarson sethmlarson merged commit c94bd5e into python:master Jan 17, 2024
1 check passed
@sethmlarson sethmlarson deleted the add-sbom-to-pydotorg branch January 17, 2024 22:26
@sethmlarson
Copy link
Collaborator Author

@hugovk Agreed, I created a shell issue for myself: #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants