load_texture: extra arguments for wrap and filter (#2383)

* load_texture: extra arguments for wrap and filter * Import order
pythonarcade · Oct 2, 2024 · d4086f2 · d4086f2
1 parent 553894e
commit d4086f2
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/arcade/context.py b/arcade/context.py
@@ -22,6 +22,7 @@
 from arcade.gl.framebuffer import Framebuffer
 from arcade.gl.program import Program
 from arcade.gl.texture import Texture2D
+from arcade.gl.types import PyGLenum
 from arcade.gl.vertex_array import Geometry
 from arcade.texture_atlas import DefaultTextureAtlas, TextureAtlasBase
 
@@ -451,8 +452,12 @@ def load_texture(
         path: str | Path,
         *,
         flip: bool = True,
+        wrap_x: PyGLenum | None = None,
+        wrap_y: PyGLenum | None = None,
+        filter: tuple[PyGLenum, PyGLenum] | None = None,
         build_mipmaps: bool = False,
         internal_format: int | None = None,
+        immutable: bool = False,
         compressed: bool = False,
     ) -> Texture2D:
         """
@@ -479,6 +484,12 @@ def load_texture(
                 Path to texture
             flip:
                 Flips the image upside down. Default is ``True``.
+            wrap_x:
+                The wrap mode for the x-axis. Default is ``None``.
+            wrap_y:
+                The wrap mode for the y-axis. Default is ``None``.
+            filter:
+                The min and mag filter. Default is ``None``.
             build_mipmaps:
                 Build mipmaps for the texture. Default is ``False``.
             internal_format (optional):
@@ -501,7 +512,11 @@ def load_texture(
             image.size,
             components=4,
             data=image.convert("RGBA").tobytes(),
+            wrap_x=wrap_x,
+            wrap_y=wrap_y,
+            filter=filter,
             internal_format=internal_format,
+            immutable=immutable,
             compressed=compressed,
         )
         image.close()

diff --git a/arcade/examples/gl/bindless_texture.py b/arcade/examples/gl/bindless_texture.py
@@ -151,9 +151,12 @@ def __init__(self):
 
         # Load enough textures to cover for each point/sprite
         for i in range(16 * 9):
-            texture = self.ctx.load_texture(next(resource_cycle))
-            texture.wrap_x = self.ctx.CLAMP_TO_EDGE
-            texture.wrap_y = self.ctx.CLAMP_TO_EDGE
+            texture = self.ctx.load_texture(
+                next(resource_cycle),
+                immutable=True,
+                wrap_x=self.ctx.CLAMP_TO_EDGE,
+                wrap_y=self.ctx.CLAMP_TO_EDGE,
+            )
             # Make sure we keep a reference to the texture to avoid GC
             self.textures.append(texture)
             # Create a texture handle and make it resident.