Pymunk import #2458
Draft
Pymunk import #2458
+21
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this looks good, but there are a few other places that reference pymunk, and because the pymunk objects may not be available, type hints and code completion might get a little confused. I don't think the code i wrote is particularly good, but i do have a branch where i also tried this you could compare with. |
|
I think the first step to doing this properly is to actually quarantine all pymunk objects to a pymunk submodule and then create a 'NotImported' object that raises an import error in 'getattr', 'call' etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #2454
This PR makes pymunk import optional and just prints the following during start.