Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
q10 committed Mar 11, 2024
1 parent 96ade97 commit 5b20bd6
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
10 changes: 5 additions & 5 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ test --verbose_explanations --verbose_failures
build --compilation_mode opt
test --compilation_mode opt

# Build FBGEMM with C17 and C++17
build:linux --cxxopt=-std=c++17
build:linux --host_cxxopt=-std=c++17
# Build FBGEMM with C17 and C++20
build:linux --cxxopt=-std=c++20
build:linux --host_cxxopt=-std=c++20
build:linux --conlyopt=-std=c17
build:linux --host_conlyopt=-std=c17
build:macos --cxxopt=-std=c++17
build:macos --host_cxxopt=-std=c++17
build:macos --cxxopt=-std=c++20
build:macos --host_cxxopt=-std=c++20
build:macos --conlyopt=-std=c17
build:macos --host_conlyopt=-std=c17
build:windows --cxxopt=/std:c++17
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/fbgemm_build.bash
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ build_fbgemm_library () {
echo "[BUILD] Running the build ..."
# shellcheck disable=SC2086
print_exec conda run --no-capture-output ${env_prefix} \
make -j VERBOSE=1
make -j 1 VERBOSE=1

cd - || return 1
}
Expand Down
4 changes: 2 additions & 2 deletions bench/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@

cmake_minimum_required(VERSION 3.16 FATAL_ERROR)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_EXTENSIONS OFF)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_VISIBILITY_PRESET hidden)
set(CMAKE_C_STANDARD 11)
set(CMAKE_C_STANDARD 17)
set(CMAKE_C_EXTENSIONS OFF)
set(CMAKE_C_STANDARD_REQUIRED ON)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ The instructions in this section apply to builds for all variants of FBGEMM_GPU.
C/C++ Compiler (GCC)
~~~~~~~~~~~~~~~~~~~~

Install a version of the GCC toolchain **that supports C++17**. The ``sysroot``
Install a version of the GCC toolchain **that supports C++20**. The ``sysroot``
package will also need to be installed to avoid issues with missing versioned
symbols with ``GLIBCXX`` when compiling FBGEMM_CPU:

Expand Down

0 comments on commit 5b20bd6

Please sign in to comment.