-
Notifications
You must be signed in to change notification settings - Fork 486
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Back out "Support FP8 scale calculation with scalar and cleanup" (#2604)
Summary: Pull Request resolved: #2604 There is garbage output issue because the new introduced Sm90ScalarBroadcast requires scalar scale that causes an issue under cudagraph. Reverting the changes in D57367680 resolves the issue. Will follow up on adding more unittests to cover similar issues and will test E2E before make those changes. Reviewed By: jianyuh Differential Revision: D57521470 fbshipit-source-id: 685054db8248ff6ef6e029451c6563ba8f37ba29
- Loading branch information
1 parent
19a91b9
commit 79aba2c
Showing
6 changed files
with
249 additions
and
143 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.