Support original indices for FBGEMM block bucketization flag #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D61102970 |
|
This pull request was exported from Phabricator. Differential Revision: D61102970 |
dstaay-fb
added a commit
to dstaay-fb/FBGEMM
that referenced
this pull request
Aug 15, 2024
…#2999) Summary: Pull Request resolved: pytorch#2999 For ZCH we want to operate in global id space; which requires expanding fbgemm block bucketization kernels to operate on global ids, not local. Purposed 'maybe_keep_orig_idx' -> 'keep_orig_idx' Reviewed By: dracifer Differential Revision: D61102970
dstaay-fb
force-pushed
the
export-D61102970
branch
from
397fc13
to
278ca29
Compare
…#2999) Summary: Pull Request resolved: pytorch#2999 For ZCH we want to operate in global id space; which requires expanding fbgemm block bucketization kernels to operate on global ids, not local. Purposed 'maybe_keep_orig_idx' -> 'keep_orig_idx' Reviewed By: dracifer Differential Revision: D61102970
|
This pull request was exported from Phabricator. Differential Revision: D61102970 |
dstaay-fb
force-pushed
the
export-D61102970
branch
from
278ca29
to
c9a55ce
Compare
|
This pull request has been merged in 7143818. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For ZCH we want to operate in global id space; which requires expanding fbgemm block bucketization kernels to operate on global ids, not local. Purposed 'maybe_keep_orig_idx' -> 'keep_orig_idx'
Differential Revision: D61102970