Revert D63335491: Multisect successfully blamed "D63335491: Refactor the GIS to reuse same autograd function for all backends" for one test failure #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the GIS to reuse same autograd function for all backends" for one test failure Summary: X-link: facebookresearch/FBGEMM#311 This diff reverts D63335491 D63335491: Refactor the GIS to reuse same autograd function for all backends by egienvalue causes the following test failure: Tests affected: - [cogwheel:cogwheel_model_import_inference_ads_v0_test#test_ads_v0_inference_model_import](https://www.internalfb.com/intern/test/281475118337004/) Here's the Multisect link: https://www.internalfb.com/multisect/11357230 Here are the tasks that are relevant to this breakage: T203477897: Test cogwheel:cogwheel_model_import_inference_ads_v0_test#test_ads_v0_inference_model_import failing for ai_test_validation The backout may land if someone accepts it. If this diff has been generated in error, you can Commandeer and Abandon it. Differential Revision: D63757977
|
This pull request was exported from Phabricator. Differential Revision: D63757977 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request has been merged in d1c40a9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/311
This diff reverts D63335491
D63335491: Refactor the GIS to reuse same autograd function for all backends by egienvalue causes the following test failure:
Tests affected:
Here's the Multisect link:
https://www.internalfb.com/multisect/11357230
Here are the tasks that are relevant to this breakage:
T203477897: Test cogwheel:cogwheel_model_import_inference_ads_v0_test#test_ads_v0_inference_model_import failing for ai_test_validation
The backout may land if someone accepts it.
If this diff has been generated in error, you can Commandeer and Abandon it.
Differential Revision: D63757977