Skip to content

Commit

Permalink
Move ShapeEnv config out of dynamo (#112933)
Browse files Browse the repository at this point in the history
Summary:
Previously there was a circular dependency between fx and dynamo that happened
to work out since ShapeEnv didn't access the config at module init time.

X-link: pytorch/pytorch#112933
Approved by: https://github.com/ezyang

Reviewed By: PaliC

Differential Revision: D51057187

fbshipit-source-id: fc38e8f8c81d2ea0dc499859acdd1fd15688a19f
  • Loading branch information
peterbell10 authored and facebook-github-bot committed Nov 7, 2023
1 parent f5b502a commit 101fae3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions userbenchmark/dynamo/dynamobench/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -3390,7 +3390,7 @@ def run(runner, args, original_dir=None):
args.repeat = 2

# Set translation validation on by default on CI accuracy runs.
torch._dynamo.config.translation_validation = True
torch.fx.experimental._config.translation_validation = True

if args.dynamic_ci_skips_only:
# Test only the incremental set of jobs whose skipped was
Expand Down Expand Up @@ -3712,7 +3712,7 @@ def run(runner, args, original_dir=None):

if args.no_translation_validation:
# Overwrite 'translation_validation' config, if specified.
torch._dynamo.config.translation_validation = False
torch.fx.experimental._config.translation_validation = False

experiment = functools.partial(experiment, args, runner.model_iter_fn)

Expand Down

0 comments on commit 101fae3

Please sign in to comment.