Skip to content

Commit

Permalink
Enable possibly-undefined error code (#118533)
Browse files Browse the repository at this point in the history
Summary:
Fixes pytorch/pytorch#118129

Suppressions automatically added with

```
import re

with open("error_file.txt", "r") as f:
    errors = f.readlines()

error_lines = {}
for error in errors:
    match = re.match(r"(.*):(\d+):\d+: error:.*\[(.*)\]", error)
    if match:
        file_path, line_number, error_type = match.groups()
        if file_path not in error_lines:
            error_lines[file_path] = {}
        error_lines[file_path][int(line_number)] = error_type

for file_path, lines in error_lines.items():
    with open(file_path, "r") as f:
        code = f.readlines()
    for line_number, error_type in sorted(lines.items(), key=lambda x: x[0], reverse=True):
        code[line_number - 1] = code[line_number - 1].rstrip() + f"  # type: ignore[{error_type}]\n"
    with open(file_path, "w") as f:
        f.writelines(code)
```

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

X-link: pytorch/pytorch#118533
Approved by: https://github.com/Skylion007, https://github.com/zou3519

Reviewed By: kit1980

Differential Revision: D53250766

Pulled By: clee2000

fbshipit-source-id: 7e54a878bf842a957c79c236e392fa4e38f3b216

Co-authored-by: Catherine Lee <csl@fb.com>
  • Loading branch information
clee2000 authored and facebook-github-bot committed Jan 31, 2024
1 parent 4aa54b2 commit e60829a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions userbenchmark/dynamo/dynamobench/_dynamo/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,7 @@ def preserve_rng_state():
with torch.utils._python_dispatch._disable_current_modes():
torch.random.set_rng_state(rng_state)
if torch.cuda.is_available():
torch.cuda.set_rng_state(cuda_rng_state)
torch.cuda.set_rng_state(cuda_rng_state) # type: ignore[possibly-undefined]


def is_jit_model(model0):
Expand Down Expand Up @@ -892,7 +892,7 @@ def timed(model, example_inputs, times=1):
result = model(*example_inputs)
synchronize()
t1 = time.perf_counter()
return result, t1 - t0
return result, t1 - t0 # type: ignore[possibly-undefined]


def check_is_cuda(gm, example_inputs):
Expand Down

0 comments on commit e60829a

Please sign in to comment.