Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the pytorch/builder script to install CUDA packages in nightly docker. #2089

Closed
xuzhao9 opened this issue Dec 18, 2023 · 1 comment
Closed

Comments

@xuzhao9
Copy link
Contributor

xuzhao9 commented Dec 18, 2023

Currently, we are building nightly dockers by copying the code from pytorch/builder.

In order to make sure the CUDA and cudnn versions are consistent with the upstream, we should use pytorch/builder scripts to install CUDA packages in the docker build.

The source of the pytorch/builder code to install cuda: https://github.com/pytorch/builder/blob/main/common/install_cuda.sh

The source of docker script installing cuda: https://github.com/pytorch/benchmark/blob/main/docker/gcp-a100-runner-dind.dockerfile#L34

In the dockerfile, we should checkout the pytorch/builder git repo and use install_cuda.sh to install the CUDA libraries.

We also want to keep using the latest CUDA version in install_cuda.sh by default, but that could be the next step.

@xuzhao9
Copy link
Contributor Author

xuzhao9 commented Jan 29, 2024

Fixed by #2138

@xuzhao9 xuzhao9 closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant